Skip to content

Image Comments UI #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PortoCode merged 21 commits into from
Mar 18, 2025
Merged

Image Comments UI #41

PortoCode merged 21 commits into from
Mar 18, 2025

Conversation

@PortoCode
Copy link
Owner

@PortoCode PortoCode commented Mar 18, 2025

  • Created a Shared UI module for reusable UI elements to avoid duplication
  • Renamed FeedViewController to ListViewController as it's now a reusable list controller for any type of cell
  • Added Dynamic Type support for scaling fonts automatically
  • Migrated to Diffable Data Sources

PortoCode added 21 commits March 16, 2025 20:35
@PortoCode
Group Feed UI tests in a new folder
fabe9c7
@PortoCode
Add CellController protocol in preparation to support any cell cont…
500b9ca 
…roller type
@PortoCode
Rename FeedViewController to ListViewController since it can now rend…
cbf7677 
…er any collection of cell controllers
@PortoCode
Replace FeedViewControllerDelegate with a closure
15c8f80
@PortoCode
Move Shared UI to new folder
d1766b0
@PortoCode
Extract shared ListViewController snapshot tests
0bdb752
@PortoCode
Add XCTFail to remind us to call assert after recording a snapshot
7ba98f9
@PortoCode
Implement Image Comments UI
b8aafce
@PortoCode
Add default implementation for optional methods in the CellController…
eb03a36 
… protocol
@PortoCode
Replace custom CellController protocol with a composition of the UITa…
b37dd34 
…bleViewDataSource/Delegate/Prefetching, so we can decouple other modules from the Shared UI module
@PortoCode
Replace protocol composition in a single type with a struct compositi…
1ab9509 
…on to prevent forcing clients to implement methods they don't care about
@PortoCode
Weakify self within onRetry closure to prevent cell from holding st…
bd021d7 
…rong references to other components
@PortoCode
Configure ErrorView programmatically so we don't duplicate layout l…
2bdd84f 
…ogic in storyboards
@PortoCode
Run ListSnapshotTests without storyboard
d2de713
@PortoCode
Enable content size category config when taking a snapshot
67a0985
@PortoCode
Replace hardcoded fonts with dynamic fonts
61e8085
@PortoCode
Use diffable data source to only reload cells when needed
1b050cd
@PortoCode
Set data source default row animation to fade
a0511b8
@PortoCode
Add UIView.makeContainer helper
f0642a3
@PortoCode
Extract table view configuration into a helper method
93840bd
@PortoCode
Configure Error View with the new UIButton.Configuration APIs
da4f0aa
@PortoCode PortoCode self-assigned this Mar 18, 2025
@PortoCode PortoCode merged commit efb7316 into main Mar 18, 2025
2 of 7 checks passed
@PortoCode PortoCode deleted the feature/image-comments/ui branch March 18, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@PortoCode PortoCode

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PortoCode