Draft
Conversation
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
Thijss
commented
Nov 12, 2025
| """Base class to build a generator for grid elements""" | ||
|
|
||
| def __init__(self, grid: Grid, seed: int) -> None: | ||
| def __init__(self, grid: Grid, seed: int | None) -> None: |
Member
Author
There was a problem hiding this comment.
piggyback: This is a valid option and the current default in the RadialGridGenerator
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
Thijss
commented
Nov 12, 2025
|
|
||
| @abstractmethod | ||
| def _get_shortest_path(self, source, target): ... | ||
| def _get_shortest_path(self, source, target) -> tuple[list[int], int]: ... |
Member
Author
There was a problem hiding this comment.
piggyback: add missing typehint
Thijss
commented
Nov 12, 2025
|
|
||
|
|
||
| def unique(array: T, **kwargs): | ||
| @overload |
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
Thijss
commented
Nov 12, 2025
| array_field = self.find_array_field(array.__class__) | ||
|
|
||
| if hasattr(array, "id"): | ||
| if isinstance(array, IdArray): |
|
Thijss
commented
Nov 12, 2025
| for branch_array in self.branch_arrays: | ||
| array = branch_array.filter(branch_ids) | ||
| if 0 < array.size != len(branch_ids): | ||
| if array.size > 0 and array.size != len(branch_ids): |
Member
Author
There was a problem hiding this comment.
piggyback: improve confusing logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
array.field_namewitharray["field_name"]ToDo: