Merged
Conversation
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
Contributor
Author
|
@mgovers can you please review. Also I'm currently not familiar with uv, can you update uv.lock accordingly. |
furqan463
commented
Jan 25, 2026
mgovers
reviewed
Jan 26, 2026
Member
mgovers
left a comment
mgovers
left a comment
There was a problem hiding this comment.
Hi @furqan463,
Thank you for figuring this out. It is indeed unfortunate that pandas did this many breaking changes. However, we cannot force users to use pandas 3.0.0 yet. Can you please have a look at my suggestions? After those are implemented, i will resolve the uv dependencies for you.
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
furqan463
commented
Jan 26, 2026
Contributor
Author
|
There are 2 warning in pandas 3.0 regarding unit/conftest.py, 7 warnings in validation tests. |
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
mgovers
approved these changes
Jan 26, 2026
Member
I resolved the conftest ones. The other validation test warnings are unrelated to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With release of pandas 3.0, the pgm-io tests are failing. This PR fixes those issues.
PR #364 will also get fixed.