Merged
Conversation
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
mgovers
reviewed
Mar 19, 2025
..._grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp
Outdated
Show resolved
Hide resolved
..._grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp
Outdated
Show resolved
Hide resolved
..._grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
nitbharambe
commented
Mar 19, 2025
..._grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp
Outdated
Show resolved
Hide resolved
nitbharambe
changed the base branch from
main
to
fix/unreachable-regulators-again
…ansformer-ranking-restriction Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
…ansformer-ranking-restriction
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
…ansformer-ranking-restriction Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
…ansformer-ranking-restriction Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com> # Conflicts: # power_grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
mgovers
reviewed
Mar 26, 2025
..._grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp
Show resolved
Hide resolved
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Member
Member
|
Added do-not-merge label, because we have not made a decision on the right implementation yet |
Member
|
If we are going to merge this branch, we should clearly document which cases we do and which we do not support in automatic tap calculations |
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
Member
Please only remove the label once we get the go signal from stakeholders. |
|
Jerry-Jinfeng-Guo
approved these changes
Apr 28, 2025
Member
Jerry-Jinfeng-Guo
left a comment
Jerry-Jinfeng-Guo
left a comment
There was a problem hiding this comment.
@figueroa1395 Could you put this in the merge queue once you see fit in the whole merging gala?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR include:
The updated implementation of automatic transformer tap changer was too restrictive on allowed cases for tap control. Meshed control of transformers was not allowed. With this PR, we shall now put the rank of transformer at the end of the mesh to a
last_rank. Controlling the slack bus is still prevented by this way.