Unreachable regulators condition is moved#929
Merged
nitbharambe merged 10 commits intomainfrom Mar 25, 2025
Merged
Conversation
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
nitbharambe
changed the title
nitbharambe
changed the title
Member
|
Should we add a minimum reproducible example, as a validation test case, that fails before the fix and passes after the order correction? |
Member
Author
Indeed, adding test |
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Member
|
The bug that originally removed the isolated transformers is introduced in b642c97 |
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
…-with-isolated-trafo Step-up transformer automatic tap changer support: patch the validation that was accidentally incorrectly removed
Jerry-Jinfeng-Guo
approved these changes
Mar 25, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We reintroduced this bug mentioned in #702 (PR: #703) for unreachable regulators which would be the reason for more failing cases
Changes proposed in this PR include:
Move the condition for unreachable regulators