Skip to content

add conda-remove-defaults to setup miniforge in CI#932

Merged
mgovers merged 1 commit intomainfrom
feature/actions-conda-default-disable
Mar 25, 2025
Merged

add conda-remove-defaults to setup miniforge in CI#932
mgovers merged 1 commit intomainfrom
feature/actions-conda-default-disable

Conversation

@mgovers
Copy link
Member

@mgovers mgovers commented Mar 25, 2025

Attempt to fix the warning about conda default channels cfr. https://github.com/PowerGridModel/power-grid-model/actions/runs/14050295856

image

Checks

  • Await CI run - double-check that the warning was fixed

NOTE

The original warning was replaced by a new one, but that has to do with the internal implementation of the setup-miniconda@v3 action, which apparently doesn't explicitly remove the original defaults until at a later step in the pipeline cfr.
https://github.com/PowerGridModel/power-grid-model/actions/runs/14054021767/job/39349486685#step:3:344 and https://github.com/PowerGridModel/power-grid-model/actions/runs/14054021767/job/39349486685#step:3:344
image

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers added the github_actions Pull requests that update GitHub Actions code label Mar 25, 2025
@mgovers mgovers requested a review from figueroa1395 March 25, 2025 07:31
@mgovers mgovers self-assigned this Mar 25, 2025
@mgovers mgovers added do-not-merge This should not be merged dependencies Pull requests that update a dependency file labels Mar 25, 2025
@sonarqubecloud
Copy link

@mgovers mgovers removed the do-not-merge This should not be merged label Mar 25, 2025
@mgovers mgovers enabled auto-merge March 25, 2025 07:55
@TonyXiang8787
Copy link
Member

@mgovers please paste the screenshot of new conda-forge build log to prove it works.

@mgovers
Copy link
Member Author

mgovers commented Mar 25, 2025

@mgovers please paste the screenshot of new conda-forge build log to prove it works.

I did in the Note section in the description

In the current main, we get the deprecation warning. In this branch, we get a log that first adds the defaults implicitly (which triggers a new warning) and then removes the defaults again. This is setup-miniconda@v3's internal implementation and while suboptimal, it still proves that we migrated correctly.

@mgovers mgovers added this pull request to the merge queue Mar 25, 2025
Merged via the queue into main with commit 06acb54 Mar 25, 2025
29 of 31 checks passed
@mgovers mgovers deleted the feature/actions-conda-default-disable branch March 25, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants