Skip to content
This repository was archived by the owner on Feb 3, 2021. It is now read-only.

Conversation

@jorgevrgs
Copy link

include footer links

jorgevrgs added 2 commits May 2, 2014 15:20
New hook footer page
New footer hook
@maximebiloe
Copy link
Contributor

Hello,

Why do you hook the module in the column and in the footer at the install ? It will display the same information twice.
That's great to offer the possibility to hook it into the footer but wouldn't it be better to hook it only in the column at the install ?
Then, if you want to display the blocklink in the footer, you'll be able to do it in the back-office.

Could you update your PR, please ?

Best regards.

@jorgevrgs
Copy link
Author

Ready, we deleted hook on install now.

@maximebiloe
Copy link
Contributor

Hi @jorgevrgs,

Thanks for your modifications.
Before merging, could you rebase your history, please ? That way, your PR will only have one commit.

Thanks in advance.
Regards.

@jorgevrgs
Copy link
Author

I'm on #9 and I see 2 files changed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants