Draft
Conversation
…s in the kinetic euler binary file, enabling an effective kinetic singular coupling matrix in GPEC. - Should we always use the un-shifted rationals for island drive physics? - Should we bother calculating some approximation of ca for kinetic resonant surfaces? Right now, I record a lot of zeros as placeholders.
… out to dcon.f to do all at once at the end of the integration
…pers to singfld and singcoup outputs. Consolidated repetitive code by storing all coupling matrices together. This is an in-flight commit, with no compile testing.
# Conflicts: # gpec/gpout.f
…side the ode and at the kinetic resonant surfaces. - Always record a displaced kinetic singular surface for every rational surface, even if it is not very singular
…o bring GPEC surface torque in line with PENTRC integrated torque. Decrease the energy and pitch angle integration tolerances in all pentrc.in files. This is after seeing little sensitivity below 1e-3 in a 2D scan of both parameters using the DIIID kinetic example.
… that are really just going to be spikes in the current and not true singularities.
…not necessarily "singularities") Here, we reduce the tolerances for marking a surface as a kinetic resonant surface. Previous tolerances found very few "singularities" in practice, which is true and the whole point of including kinetic damping terms. But now we want to diagnose the kinetic resonances even if they are not quite singular. So we have to reduce the tolerances to mark them as special surfaces in preparation for GPEC. Note, I found these uncommitted changes on portal after a long long time. I make no promises that they are complete. More work is needed.
Contributor
Author
|
@matt-pharr should look into picking this up once the RDCON resonant metric is well documented |
Contributor
Author
|
@matt-pharr does #223 mean this should be closed? |
Collaborator
|
@logan-nc I would prefer we keep this open while I am working on #223, but to signify that it is a long-term WIP I will convert it to a draft. Then, I may edit it to merge some of these changes into #223 or choose to just re-wire all the improvements in this PR from the ground up, at which point this can be closed. |
matt-pharr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like there was some good work on this in November 2017.
Even the August 2, 2021 commit was really just something I found left over in my portal project area.
Looking at the commit record, this branch
I do not remember fully from 4 years ago, but have a vague memory that this was abandoned due to
@parkjk, where should we go from here. I think we left it as a loose end because you asked for some time to consider it in more detail back in 2017...