Open
Conversation
Contributor
|
Your What do you think @parkjk ? |
Contributor
|
Any progress here @d-burg? |
Collaborator
Author
Contributor
|
Status @d-burg? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The procedure outlined in
sym.ffollows the procedure written by Fitzpatrick through equation (16) (see: Benchmark.pdf). On this first pass and as far as I can tell, I've implemented all GPEC equilibrium quantities, integrals, and matrix multiplies correctly – however, the resulting matrices do not yet follow the desired symmetry properties.One question for now: does this look like I'm calculating the J(psi_N) contour integral correctly? I'm also not totally sure about the need for
jacin this case.GPEC/stride/sym.f
Lines 148 to 165 in 4568a5c
And in the meantime, I'll continue checking through the rest of the algebra (f_S, f_L, etc) for any issues.