[Gauge invariant Helicity] Out of bounds indexing corrected #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missing-user
changed the title
Contributor
Author
|
Sorry, I initially made a mistake implementing the fix. Now the gauge is correct, only the helicity changes by a relevant amount in the test cases and the references were updated. There is a slight regression, some of the resulting Rbc, sg, Zbs terms changed in the order of 1e-12, slightly above the thresholds for the tests. With this fix, #187 is ready to merge. |
smiet
merged commit fd97ab3
into
PrincetonUniversity:gauge_invariant_helicity
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes out of bounds error mentioned in #187 . The
change by @KseniaAleynikova does cause a minor regression, everything stayed within the expected bounds.
I believe the tests were simply failing, because the newly introduced accumulators dH1 and dH2 had uninitialized memory at the beginning of the loop.