chore: Merge branch '2.4' into main#377
Merged
marien-probesys merged 4 commits intomainfrom Dec 18, 2025
Merged
Conversation
The CI was failing because, during the first test, the expected email never arrived. In fact, since 294476c and cd48561, the emails are sent asynchronously by the "worker" Docker service. On the CI, the worker wasn't started soon enough because it was started at the same time as the app service, which didn't have time to execute the migrations. So the worker was failing for a while and wasn't started during the first test. Now, the worker waits for the app to be fully ready before being started. It means that the migrations have been executed, so there is no reason for the worker to fail. Also, the tests script now waits for the worker to be healthy as well, so we are always sure that everything is started before running the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
N/A
How to test manually
N/A
Reviewer checklist