chore: Merge branch '2.4' into main #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An issue happened when there was a high number of untreated messages associated to users without the "bypass human authentication" option. Indeed, the `getSearchQuery()` could return 1000 messages concerning these users, while the 1001th message (not returned) could have concerned a user with the "bypass" option enabled. Now, we iterate on the users with the option enabled and we get their untreated messages so we are sure to always load messages that need to be loaded.
Two problems happened. First, the `Accept-Language` header was ignored when the user wasn't logged-in. It means that the French locale was always used. The refactor of the LocaleSubscriber fixes this. The second problem was that once the session expired, but that the user was logged in again through the "remember me" cookie, the locale wasn't set anymore. This is why I introduce a UserLocaleSubscriber which is triggered on "interactive login", meaning it is called both on normal login, and on "remember me" login.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
N/A
How to test manually
N/A
Reviewer checklist