Skip to content

fix: Send email notifications for confidential messages#1011

Open
Furan05 wants to merge 1 commit intomainfrom
fix/confidential-message-notifications
Open

fix: Send email notifications for confidential messages#1011
Furan05 wants to merge 1 commit intomainfrom
fix/confidential-message-notifications

Conversation

@Furan05
Copy link

@Furan05 Furan05 commented Nov 18, 2025

Closes #338

Confidential messages now send email notifications to users with the orga:see:tickets:messages:confidential permission.

Recipients are filtered using Authorizer::isGrantedForUser() when the message is confidential.

Related issue(s)

#338

How to test manually

Reviewer checklist

  • Code is manually tested
  • Permissions / authorizations are verified
  • New data can be imported
  • Interface works on both mobiles and big screens
  • Interface works in both light and dark modes
  • Interface works on both Firefox and Chrome
  • Accessibility has been tested
  • Translations are synchronized
  • Tests are up to date
  • Copyright notices are up to date
  • Documentation is up to date
  • Pull request has been reviewed and approved

@marien-probesys marien-probesys force-pushed the fix/confidential-message-notifications branch from edf7cdc to e4089c6 Compare January 16, 2026 09:53
Copy link
Member

@marien-probesys marien-probesys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bon, finalement je rebloque cette PR parce qu’après réflexion, je me rends compte que ce n’est peut-être pas une bonne idée d’envoyer la notification telle quelle. Imaginons qu’on agent la reçoive, puis y réponde sans enlever le texte de sa réponse, le client risque d’avoir accès à des informations confidentielles.

Je vais reboucler en interne pour avoir des avis, mais je vois deux pistes de solution :

  • empêcher de répondre à un message confidentiel (pas fiable, on ne peut pas toujours rattacher une réponse à un message précis)
  • envoyer une notification de type "vous avez reçu un message confidentiel, veuillez vous connecter pour y accéder"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Send notifications for private messages

2 participants