fix: Send email notifications for confidential messages#1011
Open
fix: Send email notifications for confidential messages#1011
Conversation
marien-probesys
approved these changes
Jan 16, 2026
edf7cdc to
e4089c6
Compare
marien-probesys
requested changes
Jan 16, 2026
Member
marien-probesys
left a comment
There was a problem hiding this comment.
Bon, finalement je rebloque cette PR parce qu’après réflexion, je me rends compte que ce n’est peut-être pas une bonne idée d’envoyer la notification telle quelle. Imaginons qu’on agent la reçoive, puis y réponde sans enlever le texte de sa réponse, le client risque d’avoir accès à des informations confidentielles.
Je vais reboucler en interne pour avoir des avis, mais je vois deux pistes de solution :
- empêcher de répondre à un message confidentiel (pas fiable, on ne peut pas toujours rattacher une réponse à un message précis)
- envoyer une notification de type "vous avez reçu un message confidentiel, veuillez vous connecter pour y accéder"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #338
Confidential messages now send email notifications to users with the
orga:see:tickets:messages:confidentialpermission.Recipients are filtered using
Authorizer::isGrantedForUser()when the message is confidential.Related issue(s)
#338
How to test manually
Reviewer checklist