[WIP] Smart Extract - HTIL

ProcessMaker/Http/Controllers/TaskController.php

@@ -140,7 +140,7 @@ public function edit(ProcessRequestToken $task, string $preview = '')
         $element = $task->getDefinition(true);
         $screenFields = $screenVersion ? $screenVersion->screenFilteredFields() : [];
         $taskDraftsEnabled = TaskDraft::draftsEnabled();
-
+        $isSmartExtractTask = $task->element_name === 'Manual Document Review';
         // Remove screen parent to reduce the size of the response
         $screen = $task->screen;
         $screen['parent'] = null;
@@ -190,6 +190,25 @@ public function edit(ProcessRequestToken $task, string $preview = '')
                 'datetime_format',
             ]);
             $userConfiguration = (new UserConfigurationController())->index();
+            $hitlEnabled = config('smart-extract.hitl_enabled', false) && $isSmartExtractTask;
+
+            // Build the iframe source
+            $iframeSrc = null;
+            if ($hitlEnabled) {
+                $dashboardUrl = config('smart-extract.dashboard_url');
+                $requestData = $task->processRequest->data ?? [];
+
+                $documentToken = $requestData['documentToken'] ?? null;
+                $fileId = $requestData['fileId'] ?? null;
+
+                if ($documentToken && $fileId && !empty($dashboardUrl)) {
+                    $queryParams = http_build_query([
+                        'documentToken' => $documentToken,
+                        'fileId' => $fileId,
+                    ]);
+                    $iframeSrc = $dashboardUrl . '?' . $queryParams;
+                }
+            }
 
             return view('tasks.edit', [
                 'task' => $task,
@@ -204,6 +223,8 @@ public function edit(ProcessRequestToken $task, string $preview = '')
                 'screenFields' => $screenFields,
                 'taskDraftsEnabled' => $taskDraftsEnabled,
                 'userConfiguration' => $userConfiguration,
+                'hitlEnabled' => $hitlEnabled,
+                'iframeSrc' => $iframeSrc,
             ]);
         }
     }

ProcessMaker/Http/Middleware/HideServerHeaders.php

@@ -55,7 +55,7 @@ class HideServerHeaders
     /**
      * Handle an incoming request.
      *
-     * @param  \Closure(\Illuminate\Http\Request): (\Symfony\Component\HttpFoundation\Response)  $next
+     * @param  Closure(Request): (Response)  $next
      */
     public function handle(Request $request, Closure $next): Response
     {

ProcessMaker/Http/Middleware/IsManager.php

@@ -13,7 +13,7 @@ class IsManager
     /**
      * Handle an incoming request.
      *
-     * @param  \Closure(\Illuminate\Http\Request): (\Symfony\Component\HttpFoundation\Response)  $next
+     * @param  Closure(Request): (Response)  $next
      */
     public function handle(Request $request, Closure $next): Response
     {

ProcessMaker/Http/Resources/Task.php

@@ -74,6 +74,8 @@ public function toArray($request)
 
         $this->addAssignableUsers($array, $include);
 
+        $this->mergeHitlCaseNumber($array);
+
         return $array;
     }
 
@@ -114,6 +116,28 @@ private function addAssignableUsers(&$array, $include)
         }
     }
 
+    private function mergeHitlCaseNumber(array &$array): void
+    {
+        if (!config('smart-extract.hitl_enabled')) {
+            return;
+        }
+
+        if (!empty(data_get($array, 'process_request.case_number'))) {
+            return;
+        }
+
+        $this->processRequest->loadMissing('parentRequest');
+        $parentCaseNumber = $this->processRequest->parentRequest?->case_number;
+        if (!$parentCaseNumber) {
+            return;
+        }
+
+        data_set($array, 'process_request.case_number', $parentCaseNumber);
+        if (empty($array['case_number'])) {
+            $array['case_number'] = $parentCaseNumber;
+        }
+    }
+
     /**
      * Add the active users to the list of assigned users
      *
@@ -131,7 +155,7 @@ private function addActiveAssignedUsers(array $users, array $assignedUsers)
                 ->whereNotIn('status', Process::NOT_ASSIGNABLE_USER_STATUS)
                 ->whereIn('id', $chunk)
                 ->pluck('id')->toArray();
-            $assignedUsers = array_merge($assignedUsers,$activeUsers);
+            $assignedUsers = array_merge($assignedUsers, $activeUsers);
         }
 
         return $assignedUsers;

ProcessMaker/Jobs/ErrorHandling.php

@@ -211,10 +211,59 @@ public function setDefaultsFromDataSourceConfig(array $config)
     public static function convertResponseToException($result)
     {
         if ($result['status'] === 'error') {
-            if (str_starts_with($result['message'], 'Command exceeded timeout of')) {
-                throw new ScriptTimeoutException($result['message']);
+            $rawMessage = $result['message'] ?? '';
+            if (str_starts_with((string) $rawMessage, 'Command exceeded timeout of')) {
+                throw new ScriptTimeoutException((string) $rawMessage);
+            }
+
+            $message = self::extractScriptErrorMessage($result);
+
+            if (empty($message)) {
+                $message = $rawMessage ?: 'Script execution failed with unknown error';
+            }
+
+            throw new ScriptException($message);
+        }
+    }
+
+    /**
+     * Extract a concise error message from the microservice response.
+     */
+    private static function extractScriptErrorMessage(array $result): string
+    {
+        $candidates = [
+            $result['output']['error'] ?? null,
+            $result['output']['exception'] ?? null,
+            $result['output']['stderr'] ?? null,
+            $result['output']['stdout'] ?? null,
+            $result['message'] ?? null,
+        ];
+
+        foreach ($candidates as $candidate) {
+            if (is_string($candidate) || is_numeric($candidate)) {
+                $short = self::shortenMessage((string) $candidate);
+                if (!empty($short)) {
+                    return $short;
+                }
             }
-            throw new ScriptException(json_encode($result, JSON_PRETTY_PRINT));
         }
+
+        return '';
+    }
+
+    /**
+     * Keep only the first line of the error and limit its length to avoid noisy traces.
+     */
+    private static function shortenMessage(string $message): string
+    {
+        $firstLine = strtok($message, "\n");
+        $firstLine = $firstLine === false ? $message : $firstLine;
+        $trimmed = trim($firstLine);
+
+        if (strlen($trimmed) > 400) {
+            return substr($trimmed, 0, 400) . '…';
+        }
+
+        return $trimmed;
     }
 }

ProcessMaker/Traits/TaskControllerIndexMethods.php

@@ -155,6 +155,7 @@ private function excludeNonVisibleTasks($query, $request)
     {
         $nonSystem = filter_var($request->input('non_system'), FILTER_VALIDATE_BOOLEAN);
         $allTasks = filter_var($request->input('all_tasks'), FILTER_VALIDATE_BOOLEAN);
+        $hitlEnabled = filter_var(config('smart-extract.hitl_enabled'), FILTER_VALIDATE_BOOLEAN);
         $query->when(!$allTasks, function ($query) {
             $query->where(function ($query) {
                 $query->where('element_type', '=', 'task');
@@ -164,8 +165,20 @@ private function excludeNonVisibleTasks($query, $request)
                 });
             });
         })
-            ->when($nonSystem, function ($query) {
-                $query->nonSystem();
+            ->when($nonSystem, function ($query) use ($hitlEnabled) {
+                if (!$hitlEnabled) {
+                    $query->nonSystem();
+
+                    return;
+                }
+
+                $query->where(function ($query) {
+                    $query->nonSystem();
+                    $query->orWhere(function ($query) {
+                        $query->where('element_type', '=', 'task');
+                        $query->where('element_name', '=', 'Manual Document Review');
+                    });
+                });
             });
     }
 

composer.json

@@ -173,7 +173,8 @@
                 "package-rpa": "1.1.1",
                 "package-savedsearch": "1.43.7",
                 "package-slideshow": "1.4.3",
-                "package-signature": "1.15.3",
+                "package-smart-extract": "dev-develop",
+                "package-signature": "1.15.2",
                 "package-testing": "1.8.1",
                 "package-translations": "2.14.5",
                 "package-versions": "1.13.0",

resources/js/processes/modeler/components/inspector/TaskAssignment.vue

@@ -126,10 +126,10 @@
         return this.$root.$children[0].process;
       },
       assignmentLockGetter () {
-        return _.get(this.node, "assignmentLock");
+        return _.get(this.node, "assignmentLock") || false;
       },
       allowReassignmentGetter () {
-        return _.get(this.node, "allowReassignment");
+        return _.get(this.node, "allowReassignment") || false;
       },
       assignedUserGetter () {
         let value = _.get(this.node, "assignedUsers");
@@ -249,6 +249,22 @@
       },
     },
     methods: {
+      /**
+       * Safely parse JSON string, returning empty object on error
+       * @param {string} jsonString - The JSON string to parse
+       * @returns {object} - Parsed object or empty object if parsing fails
+       */
+      safeJsonParse(jsonString) {
+        if (!jsonString) {
+          return {};
+        }
+        try {
+          return JSON.parse(jsonString);
+        } catch (e) {
+          console.warn('Failed to parse JSON:', e);
+          return {};
+        }
+      },
       getConfigurableValue(configurable) {
         switch (configurable) {
           case 'LOCK_TASK_ASSIGNMENT':

resources/js/tasks/components/TasksList.vue

@@ -496,7 +496,7 @@ export default {
       return `
       <a href="${this.openTask(record, 1)}"
          class="text-nowrap">
-         # ${processRequest.case_number || record.case_number}
+         # ${processRequest.case_number || record.case_number || ""}
       </a>`;
     },
     formatCaseTitle(processRequest, record) {

resources/views/layouts/layoutnext.blade.php

@@ -133,6 +133,7 @@ class="main flex-grow-1 h-100
 @endif
 
 @yield('js')
+@stack('scripts')
 
 @isset($addons)
   @foreach ($addons as $addon)

resources/views/tasks/edit.blade.php

@@ -87,25 +87,29 @@ class="nav-link">
             <div id="tabContent" class="tab-content tw-flex tw-flex-col tw-grow tw-overflow-y-scroll">
               <div id="tab-form" role="tabpanel" aria-labelledby="tab-form" class="tab-pane active show">
                 @can('update', $task)
-                <task
-                  ref="task"
-                  class="card border-0"
-                  v-model="formData"
-                  :initial-task-id="{{ $task->id }}"
-                  :initial-request-id="{{ $task->process_request_id }}"
-                  :screen-version="{{ $task->screen['id'] ?? null }}"
-                  :user-id="{{ Auth::user()->id }}"
-                  csrf-token="{{ csrf_token() }}"
-                  initial-loop-context="{{ $task->getLoopContext() }}"
-                  :wait-loading-listeners="true"
-                  @task-updated="taskUpdated"
-                  @updated-page-core="updatePage"
-                  @submit="submit"
-                  @completed="completed"
-                  @@error="error"
-                  @closed="closed"
-                  @redirect="redirectToTask"
-                  @form-data-changed="handleFormDataChange" />
+                  @unless($hitlEnabled)
+                    <task
+                      ref="task"
+                      class="card border-0"
+                      v-model="formData"
+                      :initial-task-id="{{ $task->id }}"
+                      :initial-request-id="{{ $task->process_request_id }}"
+                      :screen-version="{{ $task->screen['id'] ?? null }}"
+                      :user-id="{{ Auth::user()->id }}"
+                      csrf-token="{{ csrf_token() }}"
+                      initial-loop-context="{{ $task->getLoopContext() }}"
+                      :wait-loading-listeners="true"
+                      @task-updated="taskUpdated"
+                      @updated-page-core="updatePage"
+                      @submit="submit"
+                      @completed="completed"
+                      @@error="error"
+                      @closed="closed"
+                      @redirect="redirectToTask"
+                      @form-data-changed="handleFormDataChange" />
+                  @else
+                    @include('tasks.partials.hitl-iframe', ['iframeSrc' => $iframeSrc ?? null])
+                  @endunless
                 @endcan
                 <div v-if="taskHasComments">
                   <timeline :commentable_id="task.id"

resources/views/tasks/partials/hitl-iframe.blade.php

@@ -0,0 +1,22 @@
+{{-- Smart Extract Manual Edit content when HITL is enabled --}}
+@php
+  // The $iframeSrc variable is received as a parameter from edit.blade.php
+  $iframeSrc = $iframeSrc ?? null;
+@endphp
+
+@if (!empty($iframeSrc))
+  <div
+    id="manual-edit-iframe-container"
+    style="position: relative; width: 100%; height: calc(100vh - 200px); border: none; margin: 0; padding: 0;"
+  >
+    <x-package-smart-extract::iframe-loader
+      :src="$iframeSrc"
+      :title="__('Smart Extract')"
+      loading-message="{{ __('Loading dashboard') }}"
+    />
+  </div>
+@else
+  <div class="alert alert-warning">
+    {{ __('No iframe source provided for Manual Edit.') }}
+  </div>
+@endif

routes/channels.php

@@ -1,4 +1,5 @@
 <?php
+
 /*
 |--------------------------------------------------------------------------
 | Broadcast Channels

tests/Feature/Api/TaskControllerTest.php

@@ -254,10 +254,10 @@ public function testShowTaskIncludesNewProperty()
         $user = User::factory()->create();
         $this->actingAs($user);
 
-        $comments = "This is a comment";
+        $comments = 'This is a comment';
 
         $task = ProcessRequestToken::factory()->create([
-            "comments" => $comments
+            'comments' => $comments,
         ]);
 
         $this->assertEquals($comments, $task->comments);