Raise requirements

[malberts]

Summary by CodeRabbit

• Chores

  • Minimum PHP requirement raised to 8.1
  • Minimum MediaWiki requirement raised to 1.43
  • scssphp dependency bumped to 1.13.0+
  • Version 5.0.0 marked as under development

• CI Updates

  • Test and workflow matrices updated to target newer MediaWiki (REL1_44/REL1_45) and corresponding PHP versions

• Refactor

  • Internal cache handling migrated to a factory-based cache approach (no public API changes)

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Warning

Rate limit exceeded

@malberts has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 26 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 6fdd200 and c14d08e.

📒 Files selected for processing (4)

• .github/workflows/ci.yml (4 hunks)
• README.md (2 hunks)
• composer.json (2 hunks)
• src/ResourceLoaderSCSSModule.php (3 hunks)

📝 Walkthrough

Walkthrough

CI matrices updated to target newer MediaWiki and PHP versions. Package requirements and branch alias bumped for a new 5.x line. README updated with raised minimums and release notes. Cache access in SCSS module migrated from ObjectCache static use to the ObjectCacheFactory-based API.

Changes

Cohort / File(s)	Change Summary
CI & Testing Configuration /.github/workflows/ci.yml	Replaced older MediaWiki matrix entries with REL1_44 and REL1_45 (plus master) and adjusted PHP version mappings across test, code-style, PHPStan, and Psalm jobs.
Dependency & Version Requirements composer.json	Bumped PHP requirement from >=8.0 to >=8.1; upgraded scssphp/scssphp to ^1.13.0; changed branch alias from 4.x-dev → 5.x-dev.
Documentation README.md	Raised documented minimums (PHP 8.1, MediaWiki 1.43, scssphp 1.13.0) and added Release notes for version 5.0.0 (Under development).
Runtime / Cache API src/ResourceLoaderSCSSModule.php	Replaced direct ObjectCache usage with MediaWikiServices-provided ObjectCacheFactory; introduced helper to get the factory and switched to factory getInstance() / getLocalClusterInstance()->makeKey() calls.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Areas needing attention:
  • src/ResourceLoaderSCSSModule.php: correctness of ObjectCacheFactory usage and imports, and behavior parity with previous cache key semantics.
  • .github/workflows/ci.yml: verify PHP/MediaWiki version combinations are valid and match CI runner images.
  • composer.json & README.md: ensure declared minimums and dependency bump are consistent and intentional.

Possibly related PRs

• Update CI #34 — Updates CI workflow matrix entries for MediaWiki/PHP versions; strongly related to the CI matrix changes in this PR.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Raise requirements' directly describes the main change: bumping minimum versions of PHP (8.0→8.1), MediaWiki (1.39→1.43), and scssphp (1.12.1→1.13.0) across multiple configuration files.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0589d87 and 364f4da.

📒 Files selected for processing (3)

• .github/workflows/ci.yml (4 hunks)
• README.md (2 hunks)
• composer.json (2 hunks)

🔇 Additional comments (8)

README.md (2)

11-12: LGTM! Requirements correctly updated.

The updated PHP and MediaWiki minimum versions align with the PR objectives and the changes in composer.json.

---

126-132: LGTM! Release notes are clear and complete.

The version 5.0.0 release notes accurately document all three dependency bumps and appropriately mark the release as under development.

composer.json (3)

39-39: LGTM! PHP requirement correctly updated.

The PHP version bump to 8.1 is consistent with the README and appropriate for a major version release.

---

57-57: LGTM! Branch alias appropriately updated for major version.

Updating the branch alias from 4.x-dev to 5.x-dev is correct for this major version bump with breaking changes (raised minimum requirements).

---

40-40: scssphp/scssphp version 1.13.0 is valid and poses no known security concerns.

Version 1.13.0 is available on Packagist. No known security advisories or CVEs were found for this version. The package is actively maintained and can be safely used in production.

.github/workflows/ci.yml (3)

86-87: LGTM! Code style checks test minimum versions.

Testing code style with REL1_43 and PHP 8.1 correctly validates the minimum supported configuration.

---

112-113: LGTM! PHPStan checks test minimum versions.

Testing PHPStan with REL1_43 and PHP 8.1 correctly validates the minimum supported configuration.

---

173-174: LGTM! Psalm checks test minimum versions.

Testing Psalm with REL1_43 and PHP 8.1 correctly validates the minimum supported configuration.