Story #14882: make facets size configurable#2952
Open
Conversation
Collaborator
|
New Issues (131)Checkmarx found the following issues in this Pull Request
Fixed Issues (14)Great job! The following issues were fixed in this Pull Request
|
bbenaissa
force-pushed
the
story_14882_update_nodes_facets_limit
branch
from
77bb45f to
f8af7d9
Compare
bbenaissa
force-pushed
the
story_14882_update_nodes_facets_limit
branch
from
f8af7d9 to
7857742
Compare
GiooDev
requested changes
Sep 30, 2025
|
|
||
| @Value("${tree-nodes-search-facets-size:1000}") | ||
| @NotNull | ||
| private Integer treeNodesSearchFacetsSiz; |
Contributor
There was a problem hiding this comment.
Typo, il manque le e à Size
| # offline_services: # Disables online search engines in collect | ||
| # - agencies | ||
| # - archive-unit-profiles | ||
| # offline_services: # Disables online search engines in collect |
Contributor
There was a problem hiding this comment.
Pourquoi ajouter de l'indentation ici ?
|
|
||
| ontologies_file_path: {{ vitamui_folder_data }}/external_ontology_fields.json | ||
|
|
||
| tree-nodes-search-facets-size: {{ vitamui_struct.tree_nodes_search_facets_size}} |
Contributor
There was a problem hiding this comment.
Mettre un default sur les templates.
ebernard
requested changes
Oct 16, 2025
Contributor
ebernard
left a comment
ebernard
left a comment
There was a problem hiding this comment.
Trop tard pour les US sur 9.0.
Contributor
|
@bbenaissa Quel est le statut de cette MR ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Description des modifications
Type de changement
Indiquer le ou les types de changements
Documentation
Indiquer la documentation mise à jour
Tests
Indiquer comment le code à été testé (manuel, environnement, TU, etc)
Migration
Indiquer si les modifications apportées impliquent une migration sur l'existant et comment la faire
Checklist
Sélectionner les éléments de la checklist
Contributeur
Indiquer qui a développé cette fonctionnalité