-
Notifications
You must be signed in to change notification settings - Fork 6
Story #15211: Cleaning PKI. #3509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
GiooDev
wants to merge
18
commits into
develop
Choose a base branch
from
story_15211_ops_cleanup
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+959
−1,017
Draft
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
53c93f3
Story #15211: Cleaning PKI.
GiooDev fc64afb
Story #15211: Cleaning truststore and configuration.
GiooDev cdafda1
Story #15211: Keep cleaning.
GiooDev 38d4d90
Story #15211: Adding consul DNS resolution for UI and Updating upstre…
GiooDev e501137
Story #15211: Trying to update nginx configuration without upstream.
GiooDev 281920f
Story #15211: Keep trying with more ssl configuration.
GiooDev 059c208
Story #15211: Try with dedicated client and server certificates confi…
GiooDev 1a03e66
Story #15211: Disable pass for client certificates.
GiooDev 216205d
Story #15211: Do not generate keystores for ui components.
GiooDev 80edf60
Story #15211: Switch back to previous upstream configuration.
GiooDev 8d9a0f2
Story #15211: Fixing cas-server resolution while starting.
GiooDev 3773517
Story #15211: Trying without upstream.
GiooDev 250c029
Story #15211: Rollback to upstream.
GiooDev a57e703
Story #15211: Keep elements commented for testing secured UI without …
GiooDev 3fc50b4
Story #15211: Cleaning PKI scripts.
GiooDev e57457e
Story #15211: Migrate keystores and truststores from proprietary JKS …
GiooDev 1dcff27
Story #15211: Renaming variables for keystores and truststores.
GiooDev cc8cc65
Story #15211: Remove useless keystores for UI components in dev-deplo…
GiooDev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,7 +23,6 @@ function generateCerts { | |
| pki_logger "Génération des certificats serveurs" | ||
| # Zone interne | ||
| generateServerCertAndStorePassphrase security vitamui-services | ||
| generateServerAndClientCertAndStorePassphrase api-gateway vitamui-services | ||
|
|
||
| #Zone externe | ||
| generateServerAndClientCertAndStorePassphrase iam vitamui-services | ||
|
|
@@ -33,6 +32,7 @@ function generateCerts { | |
| generateServerAndClientCertAndStorePassphrase archive-search vitamui-services | ||
| generateServerAndClientCertAndStorePassphrase collect vitamui-services | ||
| generateServerAndClientCertAndStorePassphrase pastis vitamui-services | ||
| generateServerAndClientCertAndStorePassphrase api-gateway vitamui-services | ||
|
|
||
| #Zone UI | ||
| generateServerAndClientCertAndStorePassphrase ui-portal vitamui-services | ||
|
|
@@ -43,10 +43,9 @@ function generateCerts { | |
| generateServerAndClientCertAndStorePassphrase ui-archive-search vitamui-services | ||
| generateServerAndClientCertAndStorePassphrase ui-collect vitamui-services | ||
| generateServerAndClientCertAndStorePassphrase ui-pastis vitamui-services | ||
| generateServerCertAndStorePassphrase ui-design-system vitamui-services | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Pas besoin de certificat pour ui-design-system, c'est juste une page de demo des composants UI. On le laisse en http sans possibilité de le passer en https. |
||
|
|
||
| #Reverse | ||
| generateServerCertAndStorePassphrase reverse hosts_vitamui_reverseproxy vitamui-services | ||
| generateServerCertAndStorePassphrase reverse vitamui-services | ||
|
|
||
| # Example of generated client cert for a customer allowing to perform request on external APIs | ||
| # generateClientCertAndStorePassphrase customer_x client-external | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Si on laisse toutes les UI en secure: false (config par défaut, voir non configurable), on pourrait même se passer de leur générer un certificat server.
En effet, elles n'auraient plus besoin que d'un certificat client.