-
Notifications
You must be signed in to change notification settings - Fork 1
WIP: Rewrite plugin in react #720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
aristath
wants to merge
313
commits into
develop
Choose a base branch
from
ari/reactify
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Test on Playground |
Contributor
✅ Code Coverage ReportPHP Coverage (PHPUnit)
✅ PHP coverage meets threshold (40%) JavaScript Coverage (Jest)
✅ Jest coverage meets threshold (40%) 🎉 Great job maintaining/improving PHP coverage! 📊 File-level Coverage Changes (51 files)🆕 New Files
📈 Coverage Improved
📉 Coverage Decreased
ℹ️ About this report
|
7dd4357 to
73b3cf7
Compare
- Add onboard URLs, user data, and branding to prplDashboardConfig - Add progressIconHtml, homeUrl, privacyPolicyUrl to branding config - Add wrapper styles (white background, border, padding) to Welcome.js - Set icon height to 100px 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
SVG elements can't be styled with React inline styles when using dangerouslySetInnerHTML. Added inline style tag to target the SVG and set height: 100px. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add REST API endpoints for data collectors and task evaluation - Create React task registry system with TaskProvider base class - Implement task injection service for React-registered tasks - Create InteractiveTaskProvider base class for interactive tasks - Migrate Hello_World task from PHP to React as proof of concept - Remove Hello_World from PHP Tasks_Manager registration - Integrate task injection into SuggestedTasks widget This establishes the foundation for migrating all task providers from PHP to React while maintaining a thin REST API layer for data collection and WordPress operations.
- Add taskMigrationHelper.js with common patterns and data collector IDs - Add TASK_MIGRATION.md guide for migrating PHP tasks to React - Provides reference patterns and step-by-step migration instructions
- Create SamplePageTask.js React implementation - Register task in task registry - Remove from PHP Tasks_Manager registration This follows the same pattern as Hello_World task migration.
- Create BlogDescriptionTask.js React implementation - Use WordPress REST API settings endpoint to check if tagline is empty - Register task in task registry - Remove from PHP Tasks_Manager registration
…n, SEO Plugin, Remove Inactive Plugins, Permalink Structure) - Create React implementations for 5 more tasks - Register all tasks in task registry - Remove from PHP Tasks_Manager registration This continues the gradual migration pattern established with Hello_World and Sample_Page tasks.
- Remove duplicate Search_Engine_Visibility registration - Task was already migrated to React in previous commit
…ing tasks to React
…ng from PHP Tasks_Manager
…loaded Options tasks to React
…pdate Term Description tasks to React
- Remove Tasks_Interactive import from class-popover-actions.php (class deleted in round 1) - Remove broken tests from test-class-security.php that referenced deleted Tasks_Interactive class - Remove unused .prpl-columns-wrapper CSS selector (only -flex variant is used) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Remove Task_Provider_Test_Trait require from bootstrap (deleted in previous round) - Delete 10 obsolete test files that tested deleted PHP task providers/traits - Add REACT_MIGRATED_PROVIDERS blocklist to Update_130 migration This prevents migration of tasks whose providers have been migrated to React 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewriting the plugin, from PHP + Vanilla-JS to React.
Playground link