Add null guards to prevent fatal errors during pp-hosts plugin updates #743
+27
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pp-hosts (or other host plugins bundling Progress Planner) is updated, hooks registered by the old plugin version can fire during the update process. At that point, dependencies may not be available because files are being extracted, causing fatal errors like:
Call to a member function get_post_types_names() on nullClass "Progress_Planner\Activities\Maintenance" not foundThis PR fixes that by adding checks and making early exits:
get_activities__content_helpers()in Content classshould_skip_saving()methodget_total_pages()andupdate_stats()methodsclass_exists()check in Maintenance class before instantiatingActivities_Maintenance