Change VFT Windows capture API from DSHOW to MSMF #209
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
emarlfox
force-pushed
the
fix/vft-windows-msmf
branch
from
a29a541 to
2589f50
Compare
Author
|
(don't mind the force push, I was amending my commit username to appease the CLAssistant) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
On Windows, the legacy Babble client used
pygrabberto capture frames from the VFT device using DirectShow. It was invoking the COM FourCC GUID for YUV232595559-0000-0010-8000-00AA00389B71so that dshow would not try to grab RGB frames from the VFT.opencvsharpseems to be more obtuse with interfacing with dshow to get it to provide proper YUV2 frames. The result is a tragically blown-out image with intense chiaroscuro vibes occluding image features.This PR switches the WindowsVFTCapture backend to Media Foundation (MSMF) and invokes the same CvtColor conversion as LinuxVFTCapture. I also toned down the Gaussian Blur effect for better image clarity (and personal taste).
Current 1.1.0.9 RC:
Fix from this PR:
