Potential fix for padlock fields randomly disabling#110
Draft
AndrielChaoti wants to merge 2 commits intoProject-GagSpeak:mainfrom
Draft
Potential fix for padlock fields randomly disabling#110AndrielChaoti wants to merge 2 commits intoProject-GagSpeak:mainfrom
AndrielChaoti wants to merge 2 commits intoProject-GagSpeak:mainfrom
Conversation
cache could desync, and so changed to direct reference a single item from the already existing client-side caches
Contributor
Author
|
I would like someone else to look over this and make sure there isn't anything important that I missed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored CkPadlockComboBase to reference a single item directly, instead of caching a cache. Should alleviate the "lock and unlock buttons are disabled after a reconnect" issue.
I was able to reproduce that by applying and removing an item, then reconnecting. When you reopen the wardrobe, that slot that had an item in it would have the lock selection and unlock button permanently disabled until the plugin was restarted.