Open
Conversation
Contributor
|
Very good. You forgot to also add a section to the project README.md explaining your code and how to use it, you can take the sections done by the other students as inspiration. Please also change the name of the folder in flight_examples and of the t3_script.py to more descriptive names about your project, because regardless of this being your submission for the SmartLab course, your pull request will be integrated as an example of the api, just like any other. Once these issues are solved your pull request will be good for merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Código utilizado na T3 do aluno Lucas Angel Larios Prado na disciplina do smartlab.