78: Add parameter relation config to simulator workflow in workflow_c…#83
Conversation
…kflow-definition-including-smaller-and-greater-than
config/workflow_config.json
Outdated
| "key_name": "end_time" | ||
| } | ||
| ], | ||
| "parameter_relations": [ |
There was a problem hiding this comment.
Would parameter_constraints be a suitable name? (I was thinking of how such a case would be handled in the world of SQL.)
Also wondering if instead of declaring parameter_relations at this json level (which is completely fine), would it be more intuitive for users to define it at the parameter level. For instance:
{
"parameter_type": "datetime",
"key_name": "start_time",
"constraints: [
{
"relation": "smaller",
"key_2": "end_time"
}
]
"
},
Although not sure if it would make it more complicated in SDK code.
There was a problem hiding this comment.
Yes I agree, both with the 'constraints' naming and placing inside a parameter description. I would name key_2 as other_parameter.
It would be more intuitive and you can control which of the two parameters is constraint, and therefore gets the warning. For instance, if end_time is not larger than start_time I only want a warning on the end_time parameter for the mapeditor case. In some other situation you would want both parameters to get a warning.
config/workflow_config.json
Outdated
| "key_name": "end_time" | ||
| } | ||
| ], | ||
| "parameter_relations": [ |
There was a problem hiding this comment.
Yes I agree, both with the 'constraints' naming and placing inside a parameter description. I would name key_2 as other_parameter.
It would be more intuitive and you can control which of the two parameters is constraint, and therefore gets the warning. For instance, if end_time is not larger than start_time I only want a warning on the end_time parameter for the mapeditor case. In some other situation you would want both parameters to get a warning.
…kflow-definition-including-smaller-and-greater-than
…ow in the default workflow_config.json
…kflow-definition-including-smaller-and-greater-than
| @@ -1,5 +1,5 @@ | |||
| # | |||
| # This file is autogenerated by pip-compile with Python 3.11 | |||
| # This file is autogenerated by pip-compile with Python 3.10 | |||
There was a problem hiding this comment.
In the Dockerfile we use 3.11, should this also be used to compile the requirements?
| @@ -1,5 +1,5 @@ | |||
| # | |||
| # This file is autogenerated by pip-compile with Python 3.11 | |||
| # This file is autogenerated by pip-compile with Python 3.10 | |||
3 participants
…onfig.json.
TODO: Still need to update SDK once released