Update ideal thermocline storage tank#328
Merged
vanmeerkerk merged 40 commits intomainfrom Feb 12, 2026
Merged
Conversation
samvanderzwan
requested changes
Nov 20, 2025
Contributor
samvanderzwan
left a comment
samvanderzwan
left a comment
There was a problem hiding this comment.
Looked through the code some comments, I did not check the tests yet.
src/omotes_simulator_core/adapter/transforms/controller_mappers/controller_storage_mapper.py
Outdated
Show resolved
Hide resolved
src/omotes_simulator_core/entities/assets/controller/controller_storage.py
Show resolved
Hide resolved
src/omotes_simulator_core/entities/assets/controller/controller_storage.py
Outdated
Show resolved
Hide resolved
src/omotes_simulator_core/entities/assets/controller/controller_storage.py
Outdated
Show resolved
Hide resolved
src/omotes_simulator_core/entities/assets/controller/controller_storage.py
Outdated
Show resolved
Hide resolved
src/omotes_simulator_core/entities/assets/ideal_heat_storage.py
Outdated
Show resolved
Hide resolved
src/omotes_simulator_core/entities/assets/ideal_heat_storage.py
Outdated
Show resolved
Hide resolved
src/omotes_simulator_core/entities/assets/ideal_heat_storage.py
Outdated
Show resolved
Hide resolved
samvanderzwan
requested changes
Dec 11, 2025
Contributor
samvanderzwan
left a comment
samvanderzwan
left a comment
There was a problem hiding this comment.
I made some comments ans some small things need to change
src/omotes_simulator_core/entities/assets/ideal_heat_storage.py
Outdated
Show resolved
Hide resolved
src/omotes_simulator_core/entities/assets/controller/controller_storage.py
Outdated
Show resolved
Hide resolved
src/omotes_simulator_core/entities/assets/controller/controller_storage.py
Outdated
Show resolved
Hide resolved
Storage charge (+Q), discharge (-Q) while supply (-Q) and demand (+Q)
Contributor
Author
|
@samvanderzwan a new, and updated version of the buffer with all changes we recently discussed. Please re-review. |
Contributor
samvanderzwan
left a comment
samvanderzwan
left a comment
There was a problem hiding this comment.
Some minor comments. Main code looks fine. In test there are 2 things which can be improved.
src/omotes_simulator_core/entities/assets/controller/controller_storage.py
Show resolved
Hide resolved
samvanderzwan
approved these changes
Feb 12, 2026
Contributor
samvanderzwan
left a comment
samvanderzwan
left a comment
There was a problem hiding this comment.
All comments have been resolved and now it seems ok
samvanderzwan
dismissed
a stale review
No maintainer of the software so not qualified to do a review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial PR for review