Open
Conversation
Contributor
Author
|
@samvanderzwan ready for review. |
samvanderzwan
requested changes
Jan 28, 2026
Contributor
samvanderzwan
left a comment
samvanderzwan
left a comment
There was a problem hiding this comment.
Some minor comments.
It looks fine. I am missing tests for the getting of the constraints, can you add these?
src/omotes_simulator_core/adapter/transforms/controller_mappers/controller_producer_mapper.py
Outdated
Show resolved
Hide resolved
src/omotes_simulator_core/entities/assets/controller/controller_producer.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Hi @samvanderzwan I addressed all your changes. Ready for review again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added functionality for producers to be able to use production profiles. These profiles are assigned through the asset constraint attribute in esdl (as opposed to assigning the profiles to a port, like in the consumers). When creating a producer asset, the code now always checks to see if there is a profile assigned to the constraint.
These profiles are now used to regulate the maximum power a producer can generate at a given timestep. If there is no profile, or the profile is not defined at the current timestep, the controller defaults to the traditional power value, assigned through the power attribute in esdl.
These profiles are not yet compatible with the output profiles of the optimizer. This requires further work.