Skip to content

removed error handling from result handler #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mannershark merged 2 commits into from
Jul 3, 2025
Merged

removed error handling from result handler #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b78218
removed error handling from result handler
SBRTPG Jul 2, 2025
ea84b7c
fixed test to no longer require error to be thrown
SBRTPG Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions sdk/src/lib/handlers/ResultHandler.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,18 @@ describe('ResultsHandler', () => {

it('should error when not succeeded', (done) => {
handler.getResult().subscribe({
next: () => {
done.fail('Should not have succeeded');
next: (result) => {
expect(result).toEqual({
uuid: 'uuid',
logs: 'logs',
outputEsdl: '',
resultType: JobResult.ResultType.ERROR,
esdlMessagesList: [],
});
done()
},
error: (error) => {
expect(error.message).toEqual('Job uuid failed: logs');
done();
error: () => {
done.fail('should not have thrown error')
},
complete: () => {
done.fail('Should not have completed');
Expand Down
3 changes: 0 additions & 3 deletions sdk/src/lib/handlers/ResultHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ export class ResultHandler extends JobHandler {
return messages$.pipe(
map((message) => {
const result = JobResult.deserializeBinary(message.content);
if (result.getResultType() === JobResult.ResultType.ERROR) {
throw new Error(`Job ${result.getUuid()} failed: ${result.getLogs()}`);
}
return result.toObject();
})
);
Expand Down