Skip to content

Comments

Feat : 아톰 인풋 라벨 컴포넌트 UI #29

Open
JEONGHWANMIN wants to merge 13 commits intomainfrom
feature/atom-input-label
Open

Feat : 아톰 인풋 라벨 컴포넌트 UI #29
JEONGHWANMIN wants to merge 13 commits intomainfrom
feature/atom-input-label

Conversation

@JEONGHWANMIN
Copy link
Contributor

작업내용

  • 인풋 라벨 컴포넌트 UI 생성

속성

title: string;
asterisk?: boolean; (에스터리스크 사용 여부)

에스터리스크 사용 UI (위에 빨간 줄 무시)
image

에스터리스크 미사용 UI
image

@JEONGHWANMIN JEONGHWANMIN added documentation 문서 추가/수정 feature 기능 추가 design UI 디자인 변경 labels Mar 11, 2023
@JEONGHWANMIN JEONGHWANMIN self-assigned this Mar 11, 2023
@JEONGHWANMIN JEONGHWANMIN marked this pull request as draft March 11, 2023 07:44
@JEONGHWANMIN JEONGHWANMIN marked this pull request as ready for review March 11, 2023 07:52
@JEONGHWANMIN JEONGHWANMIN removed the documentation 문서 추가/수정 label Mar 11, 2023
Copy link
Member

@seonnn seonnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AtomInputLabel color 속성 관련 리뷰 추가

`;

const Asterisk = styled.span`
color: #ff7262;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asterisk도 현재 지정된 색 이외의 다른 색이 적용되는 경우도 있어서 optional property로 color를 받아서 색을 지정하는 것이 어떨까요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 좋습니다 !

추가했습니다 ~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design UI 디자인 변경 feature 기능 추가

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants