feat(PocketEventsDialogManager): add configuration support for clear … #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
PocketEventsDialogManagerclass to improve compatibility with different connection states and enhance dialog management functionality. The changes include updates to theclearDialogmethod and the addition of new imports to support the refactoring.Refactoring for connection state compatibility:
packetevents/src/main/java/io/github/projectunified/unidialog/packetevents/PocketEventsDialogManager.java: Updated theclearDialogmethod to dynamically select the appropriate dialog wrapper (WrapperConfigServerClearDialogorWrapperPlayServerClearDialog) based on the user's connection state. This ensures compatibility with bothCONFIGURATIONandPLAYconnection states.Enhancements to dialog management functionality:
packetevents/src/main/java/io/github/projectunified/unidialog/packetevents/PocketEventsDialogManager.java: Added new imports for dialog-related classes, includingWrapperCommonServerClearDialog,WrapperCommonServerShowDialog, andUser, to support the refactored functionality and expand dialog management capabilities.