Open
Conversation
A-sh2000
commented
May 4, 2024
- In the first paragraph, "This is done by incorporating Zero-Knowledge technology with Microprocessors without Interlocked Pipeline Stages (MIPS) architecture" can be improved for clarity. Maybe break it into two sentences.
- In the second paragraph, the sentence "The process of ZKM’s zkVM looks like this:" is followed by a figure, which seems a bit redundant. You can simply say "The zkVM process consists of the following steps:"
- In the numbered list, it's better to avoid using a comma after "Execution Trace" in the first item.
- In the third paragraph, the sentence "The result of this process is a Zero-Knowledge Proof for the correct execution of a program that is public with an input that might or might not be public, depending on the use case." could be clarified. Perhaps split it into two sentences for better readability.
- In the last paragraph, the phrase "an execution trace is generated, capturing the detailed sequence of operations" can be enhanced by adding "which" before "capturing" to make it clearer.
- In the last paragraph, the phrase "Then the prover generates a ZKP proof based on the program’s execution trace." seems redundant. Maybe simplify it to "The prover then generates a ZKP based on the program's execution trace."
1. In the first paragraph, "This is done by incorporating Zero-Knowledge technology with Microprocessors without Interlocked Pipeline Stages (MIPS) architecture" can be improved for clarity. Maybe break it into two sentences. 2. In the second paragraph, the sentence "The process of ZKM’s zkVM looks like this:" is followed by a figure, which seems a bit redundant. You can simply say "The zkVM process consists of the following steps:" 3. In the numbered list, it's better to avoid using a comma after "Execution Trace" in the first item. 4. In the third paragraph, the sentence "The result of this process is a Zero-Knowledge Proof for the correct execution of a program that is public with an input that might or might not be public, depending on the use case." could be clarified. Perhaps split it into two sentences for better readability. 5. In the last paragraph, the phrase "an execution trace is generated, capturing the detailed sequence of operations" can be enhanced by adding "which" before "capturing" to make it clearer. 6. In the last paragraph, the phrase "Then the prover generates a ZKP proof based on the program’s execution trace." seems redundant. Maybe simplify it to "The prover then generates a ZKP based on the program's execution trace."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.