-
Notifications
You must be signed in to change notification settings - Fork 77
[CI] Use a Stable Cache Key to prevent warnings in gh-actions #456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ParagEkbote
wants to merge
6
commits into
PrunaAI:main
Choose a base branch
from
ParagEkbote:set-stable-cache-key
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been inactive for 10 days and is now marked as stale. |
Contributor
Author
|
Not Stale. |
Contributor
Author
|
Could you please review? |
davidberenstein1957
approved these changes
Jan 13, 2026
Member
|
Thanks for the help @ParagEkbote |
minettekaum
approved these changes
Jan 15, 2026
Contributor
minettekaum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ParagEkbote for the contribution 😄 LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some of the gh-action test runs, I have observed the following warnings for the model and dataset cache not being saved correctly:
The issue stems from setting the cache key in an uncertain manner. When tests get updated or modified, a new key will be assigned and the previous cache will get invalidated.
In the updated key, we use a stable prefix
hf-cache-${{ runner.os }}-, which cleanly separates caches by operating system. The addition of${{ hashFiles('pyproject.toml') }}ensures the cache is only invalidated when your dependency configuration changes. This approach also enables partial key matching through restore keys, allowing gh-actions to fall back to compatible caches when an exact match can't be found.Could you please review?
cc: @davidberenstein1957
Related Issue
Fixes #(issue number)
Type of Change
How Has This Been Tested?
Checklist
Additional Notes