don't link to abi3 dll on windows for free-threaded build#4733
Merged
davidhewitt merged 2 commits intoPyO3:mainfrom Nov 29, 2024
Merged
don't link to abi3 dll on windows for free-threaded build#4733davidhewitt merged 2 commits intoPyO3:mainfrom
davidhewitt merged 2 commits intoPyO3:mainfrom
Conversation
ngoldbaum
approved these changes
Nov 26, 2024
Contributor
ngoldbaum
left a comment
ngoldbaum
left a comment
There was a problem hiding this comment.
Making my local copy of bcrypt depend on this git branch lets the tox tests pass when I run them on my local Windows dev setup.
Thanks for the quick fix!
Member
Author
|
Great, will get changelog pushed and merge this tomorrow perhaps. Given we just shipped 0.23.2 I might allow a couple days for more bug reports before considering 0.23.3. |
davidhewitt
added a commit
that referenced
this pull request
Nov 29, 2024
* don't link to abi3 dll on windows for free-threaded build * newsfragment
Merged
davidhewitt
added a commit
that referenced
this pull request
Dec 3, 2024
* don't link to abi3 dll on windows for free-threaded build * newsfragment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As free-threaded build doesn't support abi3, even if the abi3 features are set we should not use the abi3 dll.
Hopefully resolves the build error seen in pyca/bcrypt#925 (comment)