Add path to Ogmios v6 backend#398
Merged
theeldermillenial merged 3 commits intoPython-Cardano:mainfrom Jan 10, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #398 +/- ##
=======================================
Coverage 85.67% 85.67%
=======================================
Files 32 32
Lines 4202 4203 +1
Branches 1052 1052
=======================================
+ Hits 3600 3601 +1
Misses 423 423
Partials 179 179 ☔ View full report in Codecov by Sentry. |
nielstron
requested changes
Nov 16, 2024
Contributor
nielstron
left a comment
There was a problem hiding this comment.
looks good overall, but I think an unintended change snuck in
Collaborator
|
LGTM, pushed a minor fix. |
nielstron
approved these changes
Dec 9, 2024
f21348f
into
Python-Cardano:main
10 of 11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of months ago, I added a
pathargument to Ogmios.https://gitlab.com/viperscience/ogmios-python/-/merge_requests/13
This PR adds support for the
pathargument in the Ogmios chain context.For some additional context, the
pathargument allows you to specify a path in the IP/URL of the Ogmios endpoint. We had a specific use case for this where we wanted to serve Ogmios for different networks onmy.url.io/mainnetandmy.url.io/preprod.I don't believe the change has been deployed on Ogmios yet, so this should be merged once that change is released.