Merged
Conversation
Collaborator
|
Thank you for your contribution! I noticed that there are two pdf files in this PR. Do you mind explaining what they are for? |
added 2 commits
November 26, 2024 11:06
Contributor
Author
|
you are welcome @cffls The PDF files are 'temp files' that were used / are download by the "sign document" scripts. I've added them to .gitignore and deleted them from the repo. Let me know if you have any further questions! |
cffls
reviewed
Dec 7, 2024
cffls
approved these changes
Jan 4, 2025
Collaborator
cffls
left a comment
cffls
left a comment
There was a problem hiding this comment.
LGTM, thank you for your contribution!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #399 +/- ##
==========================================
+ Coverage 85.67% 88.09% +2.42%
==========================================
Files 32 32
Lines 4202 4210 +8
Branches 1052 1050 -2
==========================================
+ Hits 3600 3709 +109
+ Misses 423 349 -74
+ Partials 179 152 -27 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a folder under 'examples' with several specific use case scripts that have been useful for me in the past and I thought it would / could be useful for others.
Let me know if you have any questions or additional requests!