Skip to content

ExtendedSigningKey from hd wallet: use key type from class#400

Merged
cffls merged 1 commit intoPython-Cardano:mainfrom
gszabo:extended-key-from-hd-wallet
Dec 7, 2024
Merged

ExtendedSigningKey from hd wallet: use key type from class#400
cffls merged 1 commit intoPython-Cardano:mainfrom
gszabo:extended-key-from-hd-wallet

Conversation

@gszabo
Copy link
Contributor

@gszabo gszabo commented Nov 22, 2024

I noticed this small discrepancy when I tried to derive the staking key from a HD wallet and export it to JSON.

@codecov
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.79%. Comparing base (23cccaa) to head (035b0f3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #400      +/-   ##
==========================================
+ Coverage   85.62%   85.79%   +0.16%     
==========================================
  Files          32       32              
  Lines        4202     4202              
  Branches     1052     1052              
==========================================
+ Hits         3598     3605       +7     
+ Misses        424      421       -3     
+ Partials      180      176       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@cffls cffls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cffls cffls merged commit 6c2d183 into Python-Cardano:main Dec 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants