Keep the order of keys in cost models#435
Merged
cffls merged 1 commit intoPython-Cardano:mainfrom Apr 6, 2025
Merged
Conversation
Since plutus v3, sorting cost models based on the lexicographical of keys would result in wrong script data hash. We can assume the cost model from the chain context could be directly used without any sorting.
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
pycardano/plutus.py:81
- The cost model keys are still being sorted in the CBOR branch, while the non-CBOR branch now preserves the original order. Confirm if both branches should use the same ordering for consistency.
cm = IndefiniteList([cost_model[k] for k in sorted(cost_model.keys())])
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #435 +/- ##
==========================================
+ Coverage 85.14% 88.77% +3.62%
==========================================
Files 32 33 +1
Lines 4679 4757 +78
Branches 1116 1136 +20
==========================================
+ Hits 3984 4223 +239
+ Misses 551 375 -176
- Partials 144 159 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tacmota
approved these changes
Apr 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since plutus v3, sorting cost models based on the lexicographical of keys would result in wrong script data hash. We can assume the cost model from the chain context could be directly used without any sorting.