Fix transaction certificates in Conway and handle latest cardano-cli transaction commands#446
Merged
cffls merged 7 commits intoPython-Cardano:mainfrom Jun 4, 2025
KINGH242:main
Merged
Fix transaction certificates in Conway and handle latest cardano-cli transaction commands#446cffls merged 7 commits intoPython-Cardano:mainfrom KINGH242:main
cffls merged 7 commits intoPython-Cardano:mainfrom
KINGH242:main
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
==========================================
+ Coverage 88.75% 88.86% +0.11%
==========================================
Files 33 33
Lines 4792 4804 +12
Branches 730 731 +1
==========================================
+ Hits 4253 4269 +16
+ Misses 378 374 -4
Partials 161 161 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cffls
approved these changes
Jun 4, 2025
Collaborator
cffls
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fixes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces 3 small but crucial fixes.
Certificates type in TransactionBody:
certificatesfield in theTransactionBodyclass to accept either aListor aNonEmptyOrderedSetofCertificateobjects, providing compatibility with the various ways transactions can be generated.Cardano-cli Transaction submission:
cardano-clitransaction submit method command by attempting to use thelatestprefix for compatability with the latest versions with fallback to the original command.Python version compatibility:
greater_than_versioninpycardano/utils.pyto check if the current Python version is greater than or equal to a specified version. This is used to conditionally import and utilize thememberattribute from theenummodule in Python 3.13+ to handle FutureWarning.