Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #475 +/- ##
==========================================
- Coverage 90.64% 90.57% -0.08%
==========================================
Files 33 34 +1
Lines 5153 5157 +4
Branches 781 782 +1
==========================================
Hits 4671 4671
- Misses 304 306 +2
- Partials 178 180 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nielstron
requested changes
Dec 17, 2025
Contributor
|
Thanks for finally tackling this! Overall the approach is sound, just 2 minor notes. |
nielstron
approved these changes
Dec 18, 2025
Collaborator
Author
|
Thanks for reviewing and the suggestions! All tests are passing, merging now. |
Contributor
|
@cffls This is huge! Thanks. It will make things much easier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit will ensure pure python version of cbor2 is used when installing pycardano for the first time, without modifying any dependencies. Users are still free to use cbor2 if speed is preferred over correctness by setting
CBOR_C_EXETENSION=1in their environment.A dynamic cbor2 module is also exported by pycardano, which allows users to use if they want to write custom version of decoder without worrying about using the wrong cbor library with pycardano.