Use lock to avoid kernel address conflicts in nb-tester#3143
Merged
frankharkins merged 4 commits intomainfrom May 16, 2025
Merged
Use lock to avoid kernel address conflicts in nb-tester#3143frankharkins merged 4 commits intomainfrom
frankharkins merged 4 commits intomainfrom
Conversation
Not sure why filelock wasn't working, but asyncio.Lock() does work correctly (tested with print statements)
frankharkins
changed the title
Member
Author
|
I re-ran the notebook test ~10 times and didn't experience the issue, so hopefully this fixes it. |
Eric-Arellano
approved these changes
May 15, 2025
Collaborator
Eric-Arellano
left a comment
Eric-Arellano
left a comment
There was a problem hiding this comment.
Awesome! Good job using asyncio.lock rather than the filelock library
Collaborator
|
@Qiskit/docs-content-team test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses a lock to try and avoid this error when running in a GitHub action:
This is a bit of a shot in the dark because I can't reproduce it locally.
This is related to #2387, but is not necessarily a full fix as I believe there is more than one thing going on there.
Inspired by jupyter/nbclient#327