Skip to content

Conversation

@haimeng-zhang
Copy link
Collaborator

No description provided.

@qiskit-bot
Copy link
Contributor

Thanks for contributing to Qiskit documentation!

Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@abbycross
Copy link
Collaborator

@miamico is this ready content-wise for review? I can help with getting this to pass all the checks if so.

@miamico
Copy link
Collaborator

miamico commented Jan 6, 2026

@abbycross sorry to get back to you just now. Let me and Nate have a look over the latest version of the tutorial and then it should be good to go to you :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Here's some comments on this version:

  • edit the "usage estimate" line. I think we don't say the specific processor anymore but something like "Usage estimate: 7.5 minutes on a Heron r3 processor."
  • I would emphasize the fact that we are using dynamic circuits to implement interactions that go beyond the physical connectivity of the device. It took me a couple reading of the introduction to get it. Not sure whether also edit the title but for sure highlighting it in the introduction a bit more and earlier on
  • Review the standard naming of the various Step .. sections, I think there's some discrepancies with existing tutorials
  • The final plot is a little crowded. Let's use the following conventions: simulations (solid lines) experimental data (scatter plots with different markers and error bars). That hopefully cleans it up a bit

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review and comments, @miamico! I fixed the points raised above. Could you take another look?

@miamico
Copy link
Collaborator

miamico commented Jan 13, 2026

Awesome! something else that jumped out in my latest read:

  • Just clarifying question. Why does the unitary circuit implement the time evolution as Rx Rzz Rx?
    Shouldn't there be only one Rx? Or are they each half angle?
  • Let's add some more comments throughout dense parts of the code. For example, I got a bit lost reading the gen_hex_dynamic function.
  • When you plot the DC circuit layout with plot_circuit_layout I'm confused at what I'm looking at. Are the black numbered qubits the ones that are being used in the circuit? maybe just add a sentence to clarify. If so, it could also be nice to distinguish between data and ancilla qubits in this plot by giving slightly different colors
  • I'm a bit conflicted about the depth and duration plots. We show the depth plot to claim the dynamic circuits are less deep but then the total duration is longer. If we think that most errors comes from total duration of the circuit only then showing the depth savings is not useful (since the dc are anyway longer). If we want to argue that errors come from number of gates applied then we could say that the DC are longer but use much fewer gates and the errors arising during idling (or long measurement process) can be mitigated with DD more effectively than errors that arise due to many gate applications. Let's think about this point a little more and reflect our conclusions in the tutorial

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants