Skip to content

Comments

feat(roles & permissions): tokenization and addition to console-v5#2417

Open
TheoGrandin74 wants to merge 8 commits intonew-navigationfrom
feat/new-nav/org-settings-roles
Open

feat(roles & permissions): tokenization and addition to console-v5#2417
TheoGrandin74 wants to merge 8 commits intonew-navigationfrom
feat/new-nav/org-settings-roles

Conversation

@TheoGrandin74
Copy link
Contributor

@TheoGrandin74 TheoGrandin74 commented Feb 24, 2026

Summary

  • Tokenization and roles & permissions + edit roles page added
  • Migrated deprecated InputCheckbox component to new Checkbox component
  • Updated settings routing architecture for edit page
  • added suspense logic and skeleton loaders

Screenshots / Recordings

image image image

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet
Copy link
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 15d69f24-9bc1-4a8d-80fe-d1bb1b2bcd00 New Navigation
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Take rest sometimes

@TheoGrandin74 TheoGrandin74 force-pushed the feat/new-nav/org-settings-roles branch from 00371a3 to 78adcb8 Compare February 24, 2026 15:51
@TheoGrandin74 TheoGrandin74 force-pushed the feat/new-nav/org-settings-roles branch from 78adcb8 to e7f54d4 Compare February 24, 2026 15:52
@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

❌ Patch coverage is 66.23377% with 52 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (new-navigation@eea7047). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...rc/lib/settings-roles-edit/settings-roles-edit.tsx 65.90% 18 Missing and 12 partials ⚠️
.../feature/src/lib/settings-roles/settings-roles.tsx 71.05% 10 Missing and 1 partial ⚠️
...ib/settings-roles-edit/row-cluster/row-cluster.tsx 40.00% 1 Missing and 2 partials ⚠️
...ib/settings-roles-edit/row-project/row-project.tsx 25.00% 3 Missing ⚠️
...c/lib/settings-roles/create-modal/create-modal.tsx 80.00% 2 Missing and 1 partial ⚠️
...b/hooks/use-available-roles/use-available-roles.ts 0.00% 1 Missing ⚠️
...e/src/lib/hooks/use-custom-role/use-custom-role.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2417   +/-   ##
=================================================
  Coverage                  ?   44.22%           
=================================================
  Files                     ?      972           
  Lines                     ?    18586           
  Branches                  ?     5388           
=================================================
  Hits                      ?     8220           
  Misses                    ?     8880           
  Partials                  ?     1486           
Flag Coverage Δ
unittests 44.22% <66.23%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RemiBonnet RemiBonnet added the V5 label Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants