Fix empty pickle file by adding missing optional log_config argument#75
Open
brussee wants to merge 3 commits intoQuTech-Delft:developfrom
Open
Fix empty pickle file by adding missing optional log_config argument#75brussee wants to merge 3 commits intoQuTech-Delft:developfrom
brussee wants to merge 3 commits intoQuTech-Delft:developfrom
Conversation
Collaborator
|
Hi Paul, Thanks for finding and fixing this bug! However, I can't seem to reproduce your error when removing L192-L193. When I remove these all tests still work. Could you elaborate on what seems to go wrong in this case? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the optional
log_configargument toBuilder. This fixes the otherwise empty pickle file produced byBaseNetQASMConnectionon L409.Also thanks to Ravi for helping to track this bug down.
FYI:
Removing L192 & L193 from
BaseNetQASMConnection, because they are also present inBuilderL248 & L249, results in the following error while running the tests: