HashablePatternList bug: when a rule has a Literal with whitespace in it, rdflib logs warnings#6
Open
drewp wants to merge 2 commits intoRDFLib:masterfrom
Open
HashablePatternList bug: when a rule has a Literal with whitespace in it, rdflib logs warnings#6drewp wants to merge 2 commits intoRDFLib:masterfrom
drewp wants to merge 2 commits intoRDFLib:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See my post at https://groups.google.com/forum/#!topic/fuxi-discussion/43arTZCbSPo for more context and demo. This hash rewrite lets hash() do the mixing of the values instead of ever using +, which should perform faster and avoid the original bug. However, this will make some things that hashed the same before now have different hash values (and vice versa, in even rarer cases).
Using hash results to test equality is a bad practice in the first place, but I don't know the code well enough to fix that. It SEEMS like eq should be comparing the incoming 'items' values, after whatever canonicalization (sorting, ignore bnodes, etc) is supposed to happen.