pkg/lwip: fix dependencies when LWIP IPv4 is used

[krzysztof-cabaj]

Contribution description

While working on PR #21333, when I by mistake enable LWIP IPv4, Murdock detected some compilation errors
associated with dependencies (see #21333 (comment), older versions of this automatic reply).

In file included from acd.c:71:
../../include/lwip/acd.h:97:48: error: 'struct etharp_hdr' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
   97 | void acd_arp_reply(struct netif *netif, struct etharp_hdr *hdr);
      |                                                ^~~~~~~~~~
acd.c: In function 'acd_tmr':
acd.c:264:13: error: implicit declaration of function 'etharp_acd_probe' [-Werror=implicit-function-declaration]
  264 |             etharp_acd_probe(netif, &acd->ipaddr);
      |             ^~~~~~~~~~~~~~~~
acd.c:298:13: error: implicit declaration of function 'etharp_acd_announce' [-Werror=implicit-function-declaration]
  298 |             etharp_acd_announce(netif, &acd->ipaddr);
      |             ^~~~~~~~~~~~~~~~~~~
acd.c: At top level:
acd.c:376:43: error: 'struct etharp_hdr' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
  376 | acd_arp_reply(struct netif *netif, struct etharp_hdr *hdr)
      |                                           ^~~~~~~~~~

Similar error was observed and fixed for esp board in PR #21316.

This PR fixes this problem and code with LWIP_IPV4=1 passes all Murdock tests.

Testing procedure

Enable LWIP IPv4 in Makefile by setting LWIP_IPV4 ?= 1.

All Murdock compilation tests should pass.

Unfortunately, in current master some compilation tests fails.
What is interesting in my environment everything compile without problems (for example, for boards with cpu qn908x, samd5x or nrf52), so for further work and tests PR label CI: ready for build is needed.

Issues/PRs references

PR #21316
PR #21333

[riot-ci]

Murdock results

✔️ PASSED

ae20e07 pkg/lwip: add missing dependencies

Success	Failures	Total	Runtime
10341	0	10341	12m:26s

Artifacts

• Documentation preview

[krzysztof-cabaj]

@mguetschow thanks for CI: ready to build flag. I start working on fixing this issues.

[krzysztof-cabaj]

I checked and with this PR all examples which allows LWIP IPv4 (nanocopa_server, gcoap, gcoap_dtls and paqo_mqtt) are green in Murdock.

Can we move this PR little forward?

[krzysztof-cabaj]

@mguetschow, @crasbe, @benpicco, @miri64, @maribu ... sorry for broadcast ...

... but, can we move this PR little forward?

[crasbe]

I haven't used LWIP yet, so my review can't really assess the reason or logic behind the changes.

[krzysztof-cabaj]

Hmmm ... is PR #21419 causing some other issue with LWIP?

I didn't check this with details, but after rebasing to most recent version I have some new errors and this PR name is suspicious ;)

What is interesting errors appear for LWIP both IPv4 and IPv6 - on my local machine.

PR #21467 fix this issue!
Murdock is green again.

[benpicco]

Thank you for the patch!

[krzysztof-cabaj]

Dear All! Thanks for support during this PR and your valuable comments.

[mguetschow]

@krzysztof-cabaj could you explain the reasoning behind this logic regarding netdev_new_api again? I've tried to add a second network module (slipdev) to gcoap_dtls and then get the compile errors again - presumably because slipdev already pulls in netdev_new_api, but not netdev_eth:

diff --git a/examples/networking/coap/gcoap_dtls/Makefile b/examples/networking/coap/gcoap_dtls/Makefile
index 092e1c6a1d..59ea4827eb 100644
--- a/examples/networking/coap/gcoap_dtls/Makefile
+++ b/examples/networking/coap/gcoap_dtls/Makefile
@@ -54,6 +54,9 @@ USEMODULE += shell_cmds_default
 USEMODULE += ps
 USEMODULE += uri_parser
 
+USEMODULE += slipdev_stdio
+USEMODULE += slipdev_l2addr
+
 # Comment this out to disable code in RIOT that does safety checking
 # which is not needed in a production environment but helps in the
 # development process:

[krzysztof-cabaj]

I have to look for details, but when I remember, there is a problem with compiluation of LWIP for IPv4 and this solution fix this problem without changing/adding patches for LWIP. I looked at this issue (adding slip) around the weekend.

[krzysztof-cabaj]

Hmmm ... I try to reproduce your error.

I add to the gcoap_dtls example mentioned modules slipdev_stdio and slipdev_l2addr.
Next I try to compile this example for native and 'nucleo-f439zi` (contains Ethernet interface) - and everything compile without errors. Could you provide more details when you observer errors ... which BOARD you use?

[mguetschow]

Ah sorry, forgot to mention that: This happens for LWIP_IPV4=1 make -C examples/networking/coap/gcoap_dtls BOARD=nrf52840dk

[krzysztof-cabaj]

I add fix in PR #21869.