Skip to content

buildsystem: Call Buildtest with Clean Environment#21355

Closed
crasbe wants to merge 1 commit intoRIOT-OS:masterfrom
crasbe:pr/fix_buildtest
Closed

buildsystem: Call Buildtest with Clean Environment#21355
crasbe wants to merge 1 commit intoRIOT-OS:masterfrom
crasbe:pr/fix_buildtest

Conversation

@crasbe
Copy link
Contributor

@crasbe crasbe commented Apr 3, 2025

Contribution description

The builds for individual boards for the buildtest goal were not called with a clean environment, leading to the Make system building the binaries in the incorrect folder. For more details see #9742.

The change in the Makefile.include is necessary to avoid makefiles/board_alias.inc.mk printing a warning about the alias from native to native64, but other bad effects are possible from having the wrong BOARD defined.

Testing procedure

Outlined in #9742.

Issues/PRs references

Fixes #9742.

@github-actions github-actions bot added the Area: build system Area: Build system label Apr 3, 2025
@maribu
Copy link
Member

maribu commented Apr 4, 2025

Nice one!

I wonder, though, if we should just remove the buildtest command. I have been using make generate-Makefile.ci in its place for years now. We could let buildtest just call that instead IMO, plus a warning that the Makefile.ci will be updated as side effect.

@mguetschow
Copy link
Contributor

I wonder, though, if we should just remove the buildtest command.

FWIW, I didn't even know about buildtest up until now. If it adds no benefit over generate-Makefile.ci, I'd favor removing it.

@crasbe
Copy link
Contributor Author

crasbe commented Apr 4, 2025

Closed in favor of #21359.

@crasbe crasbe closed this Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: build system Area: Build system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

buildtest uses wrong build directory

3 participants