dist/tools/compile_test: specify toolchain and exit code#21534
Merged
mguetschow merged 2 commits intoRIOT-OS:masterfrom Jun 4, 2025
Merged
dist/tools/compile_test: specify toolchain and exit code#21534mguetschow merged 2 commits intoRIOT-OS:masterfrom
mguetschow merged 2 commits intoRIOT-OS:masterfrom
Conversation
mguetschow
added
Process: needs backport
mguetschow
force-pushed
the
compile-test-like-former-buildtest
branch
from
cb2b5f7 to
1227a0c
Compare
Contributor
Author
|
Obviously blocked by #21532 as well. |
crasbe
approved these changes
Jun 4, 2025
crasbe
added
the
Type: enhancement
maribu
approved these changes
Jun 4, 2025
mguetschow
force-pushed
the
compile-test-like-former-buildtest
branch
from
1227a0c to
3a3f115
Compare
Contributor
Author
|
Backport provided in #21540 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR changes
dist/tools/compile_test/compile_like_murdock.pytognu(backwards-compatible default) andllvm)Testing procedure
Let's hope no other tool was relying on the exit code being always zero, hopefully CI would catch that.
You can test the script locally with
The first should succeed, the latter fail.
Issues/PRs references
This is needed for RIOT-OS/riotdocker#256 and transitively to unblock the failing CI tests. Will need to be backported to the last release.