gnrc/rpl: float DODAG during local repair#21816
Merged
benpicco merged 2 commits intoRIOT-OS:masterfrom Dec 19, 2025
Merged
Conversation
5 tasks
crasbe
reviewed
Oct 23, 2025
30dd4b8 to
a96e5e7
Compare
Contributor
Author
|
I had to rebase to include the CI fix #21819. |
Contributor
Author
|
Friendly ping @mcr. Any chance to get a review on this? :) |
benpicco
reviewed
Dec 10, 2025
Contributor
benpicco
left a comment
There was a problem hiding this comment.
Looks good!
You want to give this a rebase though.
3bab4fb to
0e64014
Compare
benpicco
approved these changes
Dec 11, 2025
If the parent set of a router is empty and a local repair initiated, don't immediately poison all routes. Instead configure node as root of a new floating DODAG to maintain connectivity in the sub-tree. Once a different, grounded DODAG is found the node will join the new DODAG. If no other DODAG is found the floating DODAG will timeout after `CONFIG_GNRC_RPL_DODAG_FLOAT_TIMEOUT` and cleaned up..
17f746b to
cd963e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Add the option to create a temporary floating DODAG if the parent set of a node becomes empty and a local repair is started. This allows to maintain connectivity within the sub-tree, even if the uplink is temporarily gone (e.g., because a BLE connection broke). See RFC6550#Section18.2.4.
With #21759 merged, we now support switching between DODAGs. So as soon as the parent node (or any other node in the subtree) receives a DIO again from the original, grounded (i.e., non-floating) DODAG, it will switch back to that one. Children will furthermore not join the new floating DODAG in the first place, if they are still connected to the grounded DODAG through another parent.
A floating DODAG has a configurable timeout after which the DODAG will be cleaned up. If the timeout is set to 0, then the old logic for
gnrc_rpl_local_repairis retained. It just immediately poisons all routes (causing the local node to be cleared from the children's parent set) and cleans up the DODAG.Testing procedure
Can be tested with min. 3 nodes and the
gnrc_networkingexample with a BLE capable board.Set
CONFIG_GNRC_RPL_DEFAULT_LIFETIME=1(=1min). Until #21608 is merged, we can only detect a lost parent through a timeout mechanism.N{0..1}and connect them in a lineN0as RPL root for2001:db8::1=>N1andN2will join the DODAGN0andN1. After the 1min timeout,N1will set itself to be the root of a new floating DODAG. The DODAG ID is the public IP ofN1.N2will join the new floating DODAGN1andN2can still ping each otherN1orN2again toN0and callrpl send disN0Issues/PRs references
Part of #21574.