makefiles: remove DOWNLOAD_TO_STDOUT#21823
Merged
crasbe merged 1 commit intoRIOT-OS:masterfrom Oct 29, 2025
Merged
Conversation
crasbe
added
Type: cleanup
maribu
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
While working on #21813 I noticed that there is a big blob of Makefile magic in
$(RIOTBASE)/Makefile.includethat definesDOWNLOAD_TO_FILEandDOWNLOAD_TO_STDOUT. Both were introduced in #1431, but so far there is no use ofDOWNLOAD_TO_STDOUTin our sources. EvenDOWNLOAD_TO_FILEwas/is only used by two instances.Since
DOWNLOAD_TO_FILEis now essentially an Alias forDLCACHEanddlcache.shdoes all the "finding out whether to use curl or wget"-magic, the code in theMakefile.includeis essentially obsolete.Therefore I'd like to remove the
DOWNLOAD_TO_STDOUTas well, considering the only use would be to pipe something to something liketar. This conflicts with the idea of caching and reducing traffic though.Furthermore I took the opportunity to correct the documentation of
DLCACHEinmakefile/vars.inc.mkand add the information about the SHA512 checksums.Testing procedure
Check the sourcetree that no instances of
DOWNLOAD_TO_STDOUTare left. CI should also still be happy when buildingpkg/c25519andpkg/cryptocell_....Issues/PRs references
Discovered in #21813.