makefiles/utils/test: remove explicit dependency on bash#21917
Merged
AnnsAnns merged 2 commits intoRIOT-OS:masterfrom Nov 26, 2025
Merged
makefiles/utils/test: remove explicit dependency on bash#21917AnnsAnns merged 2 commits intoRIOT-OS:masterfrom
AnnsAnns merged 2 commits intoRIOT-OS:masterfrom
Conversation
crasbe
added
Type: enhancement
AnnsAnns
reviewed
Nov 26, 2025
| # OSx 'date' does not support 'date +%s%N' so rely on python instead | ||
| # It could be OSx specific but we do not have 'OS' defined here to differentiate | ||
| date_nanoseconds = $(shell python -c 'import time; print(int(time.time() * 1000000000))') | ||
| date_nanoseconds = $(shell python3 -c 'import time; print(int(time.time() * 1000000000))') |
Member
There was a problem hiding this comment.
Is python3 more universal? I'd always expect python to be there but not python3?`
Contributor
There was a problem hiding this comment.
Au contraire:
Ubuntu 22.04.5:
cbuec@W11nMate:~$ python
Command 'python' not found, did you mean:
command 'python3' from deb python3
command 'python' from deb python-is-python3
Ubuntu 24.04.1:
buechse@skyleaf:~$ python
Command 'python' not found, did you mean:
command 'python3' from deb python3
command 'python' from deb python-is-python3
Member
There was a problem hiding this comment.
Never took french in school so I can only respond with
"Oepsie doepsie, hoe meer je weet"
AnnsAnns
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Make tests succeed even on systems without
bashas default shell installed.Testing procedure
should all succeed on your favorite machine, and not print
make[1]: python: No such file or directoryanymore.Issues/PRs references
Found while testing the Alpine tinybuild containers in RIOT-OS/riotdocker#259 (comment)