Open
Conversation
github-actions
bot
added
Platform: ARM
basilfx
added
the
Type: cleanup
crasbe
added
the
CI: ready for build
Member
Author
|
A few tests results, just to prove that I did test this and the EFM32 driver does not depend on this. SLTB001a (ignore the `ccs811` error, I damaged it)
SLSTK3401a
SLSTK3402a
STK3600 (with I2C display and U8g2 test application) |
This was copied from the Gecko SDK I2C driver, but it does not add any proven value: - It does not take into account clock frequency - No other drivers have this - It works without
basilfx
force-pushed
the
feature/efm32_i2c_clock_init
branch
from
ae92f18 to
7942dd0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This was copied from the Gecko SDK I2C driver back in the days, but it does not add any proven value:
Removing this saves about 24-52 bytes (depending on series).
Testing procedure
Take any EFM32-based board, ant interact with I2C.
Issues/PRs references
None.