Open
Conversation
cd2a742 to
f7d8150
Compare
f7d8150 to
bf8fec7
Compare
Previous version dated from February 2023. Also remove several CFLAGS, that do not seem to be necessary anymore. The patch is upstreamed, so it could be removed too.
bf8fec7 to
5e6cf8d
Compare
Member
Author
|
I've created a PR for u8g2 with several upstreamed fixes: olikraus/u8g2#2753 |
mguetschow
reviewed
Feb 16, 2026
| PKG_NAME=u8g2 | ||
| PKG_URL=https://github.com/olikraus/u8g2 | ||
| PKG_VERSION=3d41860b4308d60a920f56b65e1b01c155fdfe81 | ||
| PKG_URL=https://github.com/basilfx/u8g2 |
Contributor
There was a problem hiding this comment.
Thanks for doing this! I would rather stick to the upstream repo and have the diff checked into RIOT as patches, though.
Member
Author
There was a problem hiding this comment.
Yes, that is the plan. This is part of the the following commit: REMOVE ME: test with fixed version
Once the fixes are upstreamed, I will drop that commit and update the version with the proper one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Just a version bump, the previous version dated from February 2023.
SDL support is still broken due to an issue with
getpid(see #13501). I don't own a x64 machine (with GUI) these days, to look into this.I also removed several CFLAGS and a patch, because they are not necessary anymore.
Testing procedure
Use
tests/pkg/u8g2.I've tested several combinations:
STK3600 with SSD1306 (I2C)
STK3600 with SSD1306 (SPI)
STK3600 with ASCII output
SLSTK3402a with on-board LCD
See #22080
SLSTK3401a with on-board LCD
See #22080, but with:
Native64 with ASCII output (LLVM)
Issues/PRs references
None